Ayaneo Air 1S oxp-sensors implementation broken #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The oxp-sensors mainline driver uses the wrong register for setting fan speed, so EC is the only answer. The EC config in this project seems to work.
|
Hrm, I have no idea why Github didn't notify me of this PR, sorry for the late response. You might want to consider opening a PR upstream too, this fork is mostly unmodified, it just disables the non-fan related functionality. |
|
@aarron-lee - the plot thickens. it seems that the chimeraos backports of air 1s support are incomplete until 6.12, and that mainline support didn't hit until 6.12. I think that realistically, this patch needs additional work (from me) to blacklist only when the kernel is less than 6.12. Since this is yaml, and the main fork doesn't seem to have a mechanism to selectively blocklist, how do you feel about me possibly changing more than yaml? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oxp-sensors mainline driver uses the wrong register for setting fan speed, so EC is the only answer. The EC config in this project seems to work. I'm going to work on an actual fix, starting with the ChimeraOS developers but this is needed in the meantime.