-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge SteamFork's SimpleDeckyTDP features upstream. #43
Conversation
reduction. * Set fast-limit to match the explicit TDP setting so the desired TDP is honored. * Apply temperature limits for tctl, apu, and dgpu. * Apply max-performance for additional performance improvements.
- Upstream PR: aarron-lee#43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides a few small little nits and typos, I think this all looks good to me!
One thing we will have to do though is write a migration for all users that'd be upgrading from an older version of SDTDP.
Since the DEFAULT
gpu mode was re-named to BALANCE
, anyone with DEFAULT
in their settings.json might encounter an error after updating.
It should be an easy fix though, I can write up a migration that will update the settings file to replace DEFAULT
with BALANCE
Line 233 in beea361
async def _migration(self): |
I can add the migration really quick after getting this PR fixed up and merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll followup with a migration for the DEFAULT => BALANCE, then queue up a release
Excellent! |
We maintain a few changes downstream in SteamFork that could be useful upstream. This request proposes the following changes: