Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SteamFork's SimpleDeckyTDP features upstream. #43

Merged
merged 9 commits into from
Sep 23, 2024
Merged

Merge SteamFork's SimpleDeckyTDP features upstream. #43

merged 9 commits into from
Sep 23, 2024

Conversation

fewtarius
Copy link
Contributor

We maintain a few changes downstream in SteamFork that could be useful upstream. This request proposes the following changes:

  • Deprecate and remove apu-slow-limit, as it significantly restricts APU performance. It may be desirable to reintroduce as a separate TDP slider perhaps?
  • Modify fast-limit to match the explicit TDP setting as that is the desired state (according to the slider).
  • Apply temperature limits to reduce risk of overheating.
  • Apply max-performance option to reduce stutter in some games.
  • Apply GPU modes from JELOS/SteamFork.
    • Introduce "battery" mode to force the GPU into a low power state.
    • Modify default to balanced (as it is "auto" anyway).
    • Introduce "performance" to force the GPU into the highest performance state.
    • Retains range and fixed frequency modes.
    • Re-orders slider -> Battery / Balanced / Power / Range / Fixed
    • Presents device unsupported message when ranges are not available (legacy APU devices, such as Ayaneo Air and Atari VCS).

  reduction.
* Set fast-limit to match the explicit TDP setting so the desired TDP is
  honored.
* Apply temperature limits for tctl, apu, and dgpu.
* Apply max-performance for additional performance improvements.
fewtarius added a commit to SteamFork/SimpleDeckyTDP that referenced this pull request Sep 22, 2024
Copy link
Owner

@aarron-lee aarron-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a few small little nits and typos, I think this all looks good to me!

One thing we will have to do though is write a migration for all users that'd be upgrading from an older version of SDTDP.

Since the DEFAULT gpu mode was re-named to BALANCE, anyone with DEFAULT in their settings.json might encounter an error after updating.

It should be an easy fix though, I can write up a migration that will update the settings file to replace DEFAULT with BALANCE

async def _migration(self):

I can add the migration really quick after getting this PR fixed up and merged.

src/components/atoms/GpuModeSlider.tsx Outdated Show resolved Hide resolved
src/components/atoms/GpuRangeSliders.tsx Outdated Show resolved Hide resolved
src/components/atoms/GpuModeSlider.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@aarron-lee aarron-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll followup with a migration for the DEFAULT => BALANCE, then queue up a release

@aarron-lee aarron-lee merged commit ddbc699 into aarron-lee:main Sep 23, 2024
@fewtarius
Copy link
Contributor Author

Looks good to me! I'll followup with a migration for the DEFAULT => BALANCE, then queue up a release

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants