-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new frontend #110
Feature/new frontend #110
Conversation
Making changes for new frontend Still missing the rest of handler
Not done with all the handlers, temps are there to load all the pages, missing such that the flow are setup correct between the pages, and only load the correct one.
|
Secret | Commit | Filename | Detected At | |
---|---|---|---|---|
Slack Webhook URL | 342b224 | config.yml | 23:07 February 1st, 2022 | View secret |
GitLab Token | 342b224 | config.yml | 23:07 February 1st, 2022 | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.
Our GitHub checks need improvements? Share your feedbacks
Getting the networks from the event and showing them in the team scenario
@@ -0,0 +1,11 @@ | |||
[Interface] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this used in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not used as all files in privateOLD, but wireguard.conf.tmpl is also in the new folder
The file are used here
Line 401 in 2a85617
tmpl := textTemplate.Must(textTemplate.ParseFiles(templatesBasePath + "wireguard.conf" + templatesExt)) |
Used to make the VPN config for the user.
@@ -15,16 +15,18 @@ type Team string | |||
const ( | |||
RedTeam Team = "red" | |||
BlueTeam Team = "blue" | |||
NoTeam Team = "no" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this value used in the code?
@@ -37,12 +39,37 @@ func AddUser(ctx context.Context, username, email, password, gameID string, team | |||
user.Team = team | |||
user.CreatedAt = time.Now() | |||
user.GameID = gameID | |||
user.JoinedGame = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's discuss this part, I do not get why we need this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some things that we should discuss.
The interface has a bug in the RED WG configuration file. Sometimes it gets the correct IPs in the AllowedIP, other times is just getting an IP they should not. Check the attached photo configurations: Moreover, the timer has another bug. It displays a time for Red and a time for Blue users. It appears problem when multiple users are registering. |
No description provided.