move to REST from gRPC #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtrkmn
force-pushed
the
feature/move-grpc-to-rest-#230
branch
from
6de6cc1 to
04b13a9
Compare
mrtrkmn
commented
Jul 1, 2022
mrtrkmn
commented
Jul 1, 2022
Closed
|
Since the monitor host system is quite a good indicator for us if everything is running as it is supposed to. I think we need to find a solution for it to be working without the envoy proxy :) Once this is done we can merge the changes and test on our development server. |
|
All endpoints moved to REST, on top of that, some error messages are fixed with correct responses from the server. |
3 tasks
Mikkelhost
reviewed
Jul 23, 2022
client/src/App.vue
Outdated
| export default { | ||
| name: 'app' | ||
| }; | ||
| export const daemonclient = new DaemonClient(window.location.protocol+"//"+window.location.hostname+":8000", null, null); | ||
| export const API_ENDPOINT = window.location.protocol+"//"+window.location.hostname+":8090" | ||
| export const WEBSOCKET_ENDPOINT = "wss://"+window.location.hostname+":8091" |
There was a problem hiding this comment.
Would be nice if it could detect weither or not it should be wss of ws based on if http or https was used. This is mostly since at least i am not using certs when developing locally :)
|
Changes applied @Mikkelhost |
Mikkelhost
reviewed
Jul 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs a web socket, this feature requires a discussion with @Mikkelhost>> Donetodo: check error message on display27fec03todo: check error message on displaya1492ea[ ] /admin/frontend/set/memorynot used in webclient[ ] /admin/frontend/set/cpunot used in webclient[ ] /admin/stress/event( vue component does not exists, exists only on CLI )[ ] /version( not implemented on webclient)