Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filling get only ICollection property #585

Closed

Conversation

ADIX7
Copy link

@ADIX7 ADIX7 commented Feb 22, 2021

A get-only property can not be set but if it is an ICollection and the constructor initialized it we can copy the deserialized items with Add.

This yaml currently can't be deserialized to the class below.

contents:
- asd1
- asd2
- asd3
- asd4
public class Container
{
    public List<string> Contents { get; } = new List<string>();
}

A get-only property can not be set but if it is
an ICollection and the constructor initialized it
we can copy the deserialized items with Add.
@aaubry aaubry force-pushed the master branch 2 times, most recently from d4fd04a to cb0768c Compare March 30, 2021 12:15
@aaubry
Copy link
Owner

aaubry commented Mar 30, 2021

I've reviews these changes and they seem fine. Could you add some tests to show that the feature works as intended? Thanks

@aaubry aaubry added the feedback-needed More feedback is required label Apr 1, 2021
@aaubry
Copy link
Owner

aaubry commented May 30, 2021

Any news, @ADIX7 ?

@ADIX7
Copy link
Author

ADIX7 commented Jun 4, 2021

Sorry, I didn't had any time finish this.

@aaubry aaubry mentioned this pull request Apr 29, 2022
@aaubry aaubry force-pushed the master branch 8 times, most recently from a0f8359 to 78b1ab3 Compare December 2, 2022 22:39
@EdwardCooke
Copy link
Collaborator

This PR appears to be abandoned, it's over a year old. I'm going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback-needed More feedback is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants