Make the type converters available to custom pre-processing phase visitors. #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine pushing in another breaking change in the next version, there's already going to be a couple. However, can you just add method overloads to incorporate your changes? |
stijnherreman
force-pushed
the
issue-677
branch
from
a1b9a56 to
3f75e84
Compare
|
Sure, either is fine with me. I've updated the PR to add overloads instead of replacing the existing ones. |
|
This feature has been released in version 15.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the type converters available to custom pre-processing phase visitors instead of discarding them. The type converters are necessary when inheriting from
PreProcessingPhaseObjectGraphVisitorSkeleton.The change also aligns the
WithPreProcessingPhaseObjectGraphVisitor(...)API with theWithEmissionPhaseObjectGraphVisitor(...)API.Fixes #677
There are currently no unit tests at all for this API, but I can add one if required. I'm already using this change locally to implement a custom anchor assigning visitor (see #807).