Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear button for amount inputs #836

Closed
defispartan opened this issue Jun 7, 2022 · 4 comments · Fixed by #1027
Closed

Add clear button for amount inputs #836

defispartan opened this issue Jun 7, 2022 · 4 comments · Fixed by #1027
Assignees

Comments

@defispartan
Copy link
Collaborator

input

Currently, it's quite tedious to input a custom amount after selecting the max button. You have to manually move the cursor to the end of the amount and backspace. It would be much nice to have a "clear" or "x" button to reset the amount to 0.

@iamanastasia
Copy link
Contributor

Yeah, let's improve to classic interaction with x icon. But also would be great to see abbreviation of long numbers.

Screenshot 2022-07-29 at 17 44 16

@MatthewCYLau
Copy link
Contributor

👋 Hi there! New contributor here, and this ticket looks like a fantastic newbie ticket.

What is the user journey to render AssetInput? I'm keen to pick this one up.

Thanks! 🙏

@defispartan
Copy link
Collaborator Author

Hey! Yeah this would be a great first ticket, it's mostly css contained to one component

AssetInput is rendered inside of Modal components where the user is selecting an amount: supply, borrow, repay, withdraw

@MatthewCYLau
Copy link
Contributor

👋 Raised a small PR - please let me know what you think 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants