Feat: added clear button for asset input #1027
Conversation
MatthewCYLau
changed the title
MatthewCYLau
changed the title
|
✅ CI run has succeded! |
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
| Page | Size (compressed) |
|---|---|
global |
505.62 KB (🟡 +189 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Three Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/governance |
63.46 KB (🟢 -63 B) |
569.08 KB |
/governance/proposal |
104.42 KB (🟢 -63 B) |
610.04 KB |
/governance/proposal/[proposalId] |
59.15 KB (🟢 -63 B) |
564.77 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
|
✅ CI run has succeded! |
|
@iamanastasia preview link |
|
Hey @grothem Thanks for the link. Although something is not working there. The X icon is not clickable. |
|
Interesting - it is certainly functionally locally on my development laptop (classic) My wallet is sadly empty. Is there a way to render Asset Input in the above feature branch environment? I'm keen to poke around myself as well thanks! 🙏 |
|
@MatthewCYLau you can run the UI against a tenderly fork so you can play around without using real funds. There's a section in the contributing file that explains how to do that: https://github.com/aave/interface/blob/main/CONTRIBUTING.md#run-on-a-fork You would do those steps after you've created the fork. You should be able to create a free account and make a fork through tenderly https://tenderly.co Let me know if you run into any issues! |
|
Thank you, @grothem 🙏 However, I'm still confused to why this seemingly small button is working fine on my local feature branch, but apparently not clickable on the feature branch environment 😅 Would any developers know if I've missed something obvious on how I'm using |
|
Oh I see the issue, the button is being disabled if |
|
Okay cool! I've updated condition to only disable button when |
|
✅ CI run has succeded! |
|
|
@MatthewCYLau @grothem It works! Amazing! Now I don't have to struggle on mobile screens :D I wonder can we also add these changes:
|
|
@iamanastasia thank you for the feedback 🙏 I've updated the code based on your suggestions. Please let me know what you think 🙏
|
|
✅ CI run has succeded! |
|
|
@MatthewCYLau that was fast 🤔 It works, and it looks great, thank you so much! |
|
Amazing - thank you for the UI review 🎉 @grothem do let me know if this could be approved, and merged 🙏 |
CancelIcon