feat: governance UI hash preview #976
Conversation
| @@ -88,7 +88,7 @@ export function ProposalsList({ proposals: initialProposals }: GovernancePagePro | |||
| } | |||
|
|
|||
| usePolling(fetchNewProposals, 60000, false, [proposals.length]); | |||
| usePolling(updatePendingProposals, 15000, false, [proposals.length]); | |||
| usePolling(updatePendingProposals, 30000, false, [proposals.length]); | |||
There was a problem hiding this comment.
there's around 100 votes in 5 days... seems a bit unreasonable to refetch every 15s, even 30 seems unreasonable, but i guess small steps are better suited to test if someone complains.
| async function updateProposal() { | ||
| const { values, ...rest } = await governanceContract.getProposal({ proposalId: id }); | ||
| setProposal(await enhanceProposalWithTimes(rest)); | ||
| async function initialize() { |
There was a problem hiding this comment.
this was a bit unnecessary complex as the proposal and ipfs fetching where made independent although they belong together.
| } | ||
|
|
||
| // poll every 10s | ||
| usePolling( |
There was a problem hiding this comment.
this polling effectively resulted in double fetching of everything as ProposalPage is polling as well
|
❌ CI run has failed! |
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
| Page | Size (compressed) |
|---|---|
global |
505.44 KB (🟡 +2 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Page Added
The following page was added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load |
|---|---|---|
/governance/ipfs-preview |
104.3 KB |
609.74 KB |
Three Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/governance |
63.52 KB (-3 B) |
568.96 KB |
/governance/proposal |
104.46 KB (🟢 -26 B) |
609.9 KB |
/governance/proposal/[proposalId] |
59.22 KB (🟡 +7 B) |
564.66 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
|
Pls create an issue as well @sakulstra |
|
@defispartan created #984 and #985 for this. |
Co-authored-by: Andrew Schmidt <[email protected]>
|
@defispartan sorry missed your comment, looking forward to see this merged. |
|
✅ CI run has succeded! |
|
adds a hidden page which can be used to preview an ipfs hash. This is to prevent issues like the one with oneInch where a wrong ipfs hash was submitted.