Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tran UI quits on typing q in password box #38

Closed
mattiasbonte opened this issue Jul 31, 2022 · 5 comments
Closed

Tran UI quits on typing q in password box #38

mattiasbonte opened this issue Jul 31, 2022 · 5 comments

Comments

@mattiasbonte
Copy link

Hello,

When typing in the receiver password in the tran UI, the application quits upon typing q.

Expected behavior is to see the the ui's keybinds disabled when typing in the password?

Cheers!
@abdfnx
Copy link
Owner

abdfnx commented Jul 31, 2022

ok, I will fix it right now

abdfnx added a commit that referenced this issue Jul 31, 2022
@abdfnx
remove q key from tran keys #38
eb7f65e
@abdfnx
Copy link
Owner

abdfnx commented Jul 31, 2022

fixed in tran version v0.1.4

@abdfnx abdfnx closed this as completed Jul 31, 2022
@mattiasbonte
Copy link
Author

Hey, thanks! Btw, just a thought, but wouldn't it be better instead of deleting the q key, making it so that when using the password prompt the keymaps are ignored?

The reason why I like the q key is because a lot of cli apps. (ex lazygit, lazydocker, nnn...) all use q as a keybind for quitting the application.

@abdfnx
Copy link
Owner

abdfnx commented Jul 31, 2022

Hmmmm, it's a great idea, I will work on it

@abdfnx
Copy link
Owner

abdfnx commented Jul 31, 2022

done, checkout the new version of tran v0.1.41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abdfnx @mattiasbonte