Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle requirements syntax more simply and parse Poetry dependencies #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dmyersturnbull
Copy link

Fantastic tool. I wanted to use it for my project but ran into problems.
Basically, I needed to include Poetry dependencies and allow hashes listed in requirements.txt files.

Here are the changes:

  • Hashes, which are permitted in requirements.txt, now work
  • Use a simple regex instead of parse_requirements (handles more cases, like hashes)
  • Parse runtime Poetry dependencies (tool.poetry.dependencies)
  • Bumped pre-commit versions & ran black
  • Fixed a few (very) minor bugs
  • Used pathlib because it's much simpler and python 3.6 is required anyway

Sorry about the mixed changes (pathlib, f-expressions, etc) -- I just made those edits while reading the code.

(This is a draft edit -- I didn't add tests yet.)

@abduhbm
Copy link
Owner

abduhbm commented Jul 6, 2021

Thanks @dmyersturnbull !
there are few CI errors that need to be fixed and also adding tests for poetry and hashes.

@abduhbm abduhbm self-requested a review July 16, 2021 15:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants