🐛 Fix uncaught exception when previewing a CSV

Fixes #41, fixes #43, fixes #44, fixes #46, fixes #47
abe33 · Apr 28, 2016 · dbe569d · dbe569d
1 parent 5154a85
commit dbe569d
Show file tree

Hide file tree

Showing 3 changed files with 106 additions and 1 deletion.
diff --git a/lib/csv-editor-element.coffee b/lib/csv-editor-element.coffee
@@ -59,6 +59,7 @@ class CSVEditorElement extends HTMLElement
 
     @subscriptions.add @model.onDidFailOpen ({err}) =>
       @hideProgress()
+      @createFormView()
       @form.alert(err.message)
 
     @subscriptions.add @model.onDidOpen ({editor}) =>
@@ -89,6 +90,8 @@ class CSVEditorElement extends HTMLElement
     delete @tableElement
 
   createFormView: ->
+    return if @form?
+
     @removeTableEditor()
 
     @formContainer = document.createElement('div')

diff --git a/lib/csv-editor.coffee b/lib/csv-editor.coffee
@@ -364,7 +364,7 @@ class CSVEditor
         input.stop()
         input.removeListener 'readable', read
         input.removeListener 'end', end
-        input.removeListener 'error', error
+        # input.removeListener 'error', error
         resolve(output[0...limit])
 
       read = ->

diff --git a/spec/fixtures/failing-after-preview.csv b/spec/fixtures/failing-after-preview.csv
@@ -0,0 +1,102 @@
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+foo;bar;baz
+"foo";"bar";"baz"