Major Bug Fixes and Improvements (Fixes #61) #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extended build-script sysroot patch to `RTBuilder_32b`. - Replaced incorrect `RPI_TYPE` with `FOLDER_VERSION`. - Replaced `OS_TYPE` with `RPIOS_TYPE` in `RTBuilder_64b. - Added Buster and Stretch native support for `RTBuilder_64b` build script.
- Updated CI Bash scripts with new `-o` flag to support OS selection. - Updated YAMLs to include buster & stretch Pi OS support. - Updated and added new docs.
abhiTronix
added
Bug 🐛
visglz
reviewed
Jan 25, 2021
build-scripts/RTBuilder_32b
Outdated
| VERBOSE=1 | ||
| echo "Info: Activated verbose output!" | ||
| echo "" | ||
| set -eov pipefail # Set verbose mode. |
There was a problem hiding this comment.
Hm. The script will fail on error only if someone chooses the verbose option. Errors would still be silently ignored otherwise.
Wouldn't it make sense to put set -eo pipefail at the top of every script and call set -v during cmdline parsing in scripts which support the verbose option?
* Strip on compiler install (#39) * This drastically reduces extracted size from 1.7GB to 477MB * Followup to pull request #62 * Set "set -eo pipefail" at top of script. Set "set -v" only for verbose mode * Fix wget download of linux kernel * The out wget was failing because of multiple lines. Only consider topmost line with most recent file)
"set -eo pipefail" is already set at top of script.
Strip compiler executables and minor fixes
- Updated strip patch for all bash-scripts for smaller binary size. - Updated assets. - Updated docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61