Skip to content

Commit

Permalink
Refactor s3_bucket_notifications to support SNS / SQS (ansible-collec…
Browse files Browse the repository at this point in the history
…tions#940)

Refactor s3_bucket_notifications to support SNS / SQS

SUMMARY
Refactor s3_bucket_notifications to extend module to support the extra targets of SNS and SQS along with the currently supported Lambda functions.
Summary of changes:

Refactor module to support SNS/SQS targets along with current Lambda function support.
Fix check mode coverage
Update integration tests to more comprehensive cover functionality.
Update documentation in sns_topic and sqs_queue modules to add policy setting example.

Fixes: ansible-collections#140
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_bucket_notifications
ADDITIONAL INFORMATION
https://boto3.amazonaws.com/v1/documentation/api/1.16.0/reference/services/s3.html#S3.Client.put_bucket_notification_configuration

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>
  • Loading branch information
marknet15 authored Mar 28, 2022
1 parent 8371ffc commit fba642e
Show file tree
Hide file tree
Showing 3 changed files with 301 additions and 101 deletions.
Loading

0 comments on commit fba642e

Please sign in to comment.