Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output the json #21

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Output the json #21

merged 1 commit into from
Feb 1, 2021

Conversation

Crisfole
Copy link
Contributor

@Crisfole Crisfole commented Jan 6, 2021

Slack returns information from its api endpoints. This PR exposes that information in the response output parameter for future steps.

This is especially useful for allowing threads since the chat.postMessage api endpoint allows using thread_ts to indicate the message is a response to a specific post.

@abinoda abinoda merged commit 3708559 into abinoda:master Feb 1, 2021
@greglarkin
Copy link

The recent merge appears to have caused a bug due to a missing JSON executable. Can you please review the change and comment on that?

New error seen:
/entrypoint.sh: line 9: JSON: not found

@abinoda abinoda mentioned this pull request Feb 2, 2021
@abinoda
Copy link
Owner

abinoda commented Feb 2, 2021

@greglarkin Reverted #22

@Crisfole
Copy link
Contributor Author

Crisfole commented Feb 2, 2021

Oh, that's a whitespace bug: JSON=$( would fix it. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants