Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implicit strcasecmp by addind <strings.h> #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix implicit strcasecmp by addind <strings.h> #125

wants to merge 1 commit into from

Conversation

concatime
Copy link

No description provided.

abishekvashok
abishekvashok requested changes May 4, 2021
View reviewed changes
Copy link
Owner

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we really need it - string.h is the standard implementation.

@concatime
Copy link
Author

Not really. See the POSIX man page: https://pubs.opengroup.org/onlinepubs/9699919799/functions/strcasecmp.html. It clearly states #include <strings.h>.

@abishekvashok
Copy link
Owner

Not really. See the POSIX man page: https://pubs.opengroup.org/onlinepubs/9699919799/functions/strcasecmp.html. It clearly states #include <strings.h>.

Yeah it does! But is it supported widely enough?

@abishekvashok abishekvashok added the Changes requested Changes have been requested for this PR. label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abishekvashok abishekvashok abishekvashok requested changes

Assignees
No one assigned
Labels
Changes requested Changes have been requested for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@concatime @abishekvashok