Fix signal handlers and memory related bugs #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By running the program in Valgrind and inspecting the code visually, I have uncovered some memory related bugs. I belive this set of commits fixes those bugs. These bugs were:
struct cmatrix
, was allocated withsizeof(cmatrix)
, asmatrix = nmalloc(sizeof(cmatrix) * (LINES + 1));
. This did not cause a problem because, by coincidence, the struct contained twoint
s which in total have the size of a pointer. I fixed that allocation, and also improved the allocation strategy by allocating all the rows at once, making the free'ing logic simpler and more efficient.Also, I've noticed that the signal handlers called non signal-safe functions, which poses some serious problems if multiple
SIGWINCH
es arrived within short intervals. To observe the problematic behaviour, one can resize the terminal multiple times very quickly. This generally leads to a segmentation fault. I fixed this by making the signal handler set a global variable to indicate the signal, and checking this variable at each iteration of the main loop and taking the appropriate action.