Only restores TERM when it's changed. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only when `-f` force `TERM=linux` is used and there was a change of `$TERM`. Since, the forcing the TERM uses `putenv(3)`, replaced `system(3)` call to be consistent and to get rid of compilation warning of ignoring the return value. Note: using `setenv(3)` is cleaner, as we only needs to keep preserved TERM value, no need to format a `"TERM=foobar"` string. However, as the comment L388 stated that `putenv` is more common on non-Linux, so keeping this way.
|
I realized checking Should do nearly the same, if we run in shell or the launcher supports environment variable settings, even the latter does not, a simple wrapping Does anyone actually use the option? Do we really need it? 2018-01-31T05:12:45Z: |
abishekvashok
approved these changes
Feb 2, 2018
|
Thanks flr that. We can update to setenv() but that's not a priority. I've opened an issue # |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to switch to
setenv, but I think that requires @abishekvashok's approval, I'd add another commit, if it's okay to switch.I think the following comment might be outdated (no idea when it was commented):
cmatrix/cmatrix.c
Lines 387 to 391 in 5cfe816
From manpage of
setenv(3), it conforms to POSIX.1-2001, POSIX.1-2008, 4.3BSD, they were long ago, not sure if that statement in the comment still stands in the current status.There are a few pages about
putenvandsetenv: 1, 2, 3.