add osx build on Travis CI #39
Conversation
CMake builds failed on basically 93fd357 [1] on OS X since termio.h isn't present. [1]: https://travis-ci.org/livibetter/cmatrix/builds/337114240 cmatrix.c do not need to include both termios.h and termio.h, the latter is a wrapper on Linux, on POSIX, the former would do. CMake should check the header files, not defining blindly, although it's not needed as now cmatrix.c only includes one of the headers, however, it's a good practice, but it should also halt the build process if neither is found.
|
nice! :-) i am unfamiliar to autotools (never used it as a dev, only as a user). therefore, to me, it looks very complicated and... i could not say why we need it, but i would also not feel equipped to discuss this. i can just say, that i would of course like to deal only with cmake, for any future changes i would potentially add (though i have none planned). |
|
@hoijui I am okay with anything, but just one, because using two systems means we must maintain both, why do we want to torture ourselves? The only thing I don't like CMake is it doesn't come with As for autotools, I think there are lots of reasons (rants) on the Internet. |
After reading #16, even I don't have OS X, I tried to add osx build to see, and apparently, CMatrix builds natively with the default OS X environment that Travis CI provides, so I decided to create this PR.
The current CMake build script in 93fd357 hit a small problem, fixed with the second commit 5aeb8c2. I am not very familiar with CMake, there might be a cleaner way to do it, I opted not to use
configure_fileasconfig.his-DEXCLUDE_CONFIG_Hit would require me to go through more codes.@abishekvashok do we really need to support two build systems? (a new issue to discuss if you deem necessary) /cc @hoijui