Rename things for Ably #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the regexp /(?<!ART)SR(?!unLoop)(?!ange)/. And then handle the consequent changes that this requires - namely, renaming files and updating the README.
This in particular affects the framework bundle identifiers, so that our fork can coexist alongside the Facebook version.
Closed
QuintinWillison
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Looks good to me, delivering the rename per what was agreed. Thanks. 😁
In terms of your questions:
- Failing Tests downstream: I can't see those relating to this change so we'll deal with that when we come to bring this in to
ably-cocoa. - Library Version Number: Elsewhere we tend to create dedicated release PRs - which will run along the lines of what's documented in the
ably-cocoareadme. So far in this repository discipline has been low and I can see both @ricardopereira and I have just committed version bumps straight to the main branch. 🙄 - I'm happy for you to either create a subsequent, dedicated release PR (only really needs to changes.version) or simply add a commit to this PR, as you prefer.
|
Great, thanks @QuintinWillison. I've added a commit to this PR, bumping the version. As discussed in Slack, I'll merge this and push a tag. Once I've been granted CocoaPods trunk access, I'll push a new version of the pod, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
This is a preparatory step on the road to compiling SocketRocket directly into ably-cocoa, as described in this comment on ably/ably-cocoa#949.
It changes the naming so that things look like Ably code - specifically, replacing the
SRnamespace withARTSR.With this change, an application could in theory use both our SocketRocket fork and its own version of SocketRocket without experiencing any issues.
Notes
Normally, in a fork, a big rename like this would be something to be very careful about because it makes it very difficult to merge further changes from upstream. But the upstream project is well and truly dead, so I don't think we need be concerned.
Questions for reviewers
Cartfilein ably-cocoa to point to this changed version, and I had 3 failing tests when running the tests inside Xcode 12. But I don't know whether that's to be expected or not. And I also pushed it to a private CocoaPods repository and checked that I was able to compile an app that uses this version of the library.What's next