Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: combine react and core packages into one #448

Merged
merged 4 commits into from
Jan 17, 2025
Merged

refactor: combine react and core packages into one #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b6948c
refactor: combine react and core packages into one
AndyTWF Jan 10, 2025
543e006
dev: add node engine version to package.json
AndyTWF Jan 12, 2025
8c55188
dev: fix for node 18
AndyTWF Jan 13, 2025
9b704b0
dev: add node 22 build
AndyTWF Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .github/workflows/dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
branches:
- main

env:
BASE_NODE_VERSION: 22

jobs:
audit:
runs-on: ubuntu-latest
Expand All @@ -15,7 +18,7 @@ jobs:
submodules: true
- uses: actions/setup-node@v1
with:
node-version: 20
node-version: ${{ env.BASE_NODE_VERSION }}
- run: npm ci
- run: npm audit --production
format-check:
Expand All @@ -26,7 +29,7 @@ jobs:
submodules: true
- uses: actions/setup-node@v1
with:
node-version: 20
node-version: ${{ env.BASE_NODE_VERSION }}
- run: npm ci
- run: npm run format:check
lint:
Expand All @@ -37,7 +40,7 @@ jobs:
submodules: true
- uses: actions/setup-node@v1
with:
node-version: 20
node-version: ${{ env.BASE_NODE_VERSION }}
- run: npm ci
- run: npm run lint
test-typescript:
Expand All @@ -48,25 +51,29 @@ jobs:
submodules: true
- uses: actions/setup-node@v1
with:
node-version: 20
node-version: ${{ env.BASE_NODE_VERSION }}
- run: npm ci
- run: npm run test:typescript
test:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
strategy:
matrix:
node-version: [18, 20, 22]
name: test node ${{ matrix.node-version }}
steps:
- uses: actions/checkout@v2
with:
submodules: true
- uses: actions/setup-node@v1
with:
node-version: 20
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm run test
- uses: davelosert/vitest-coverage-report-action@v2
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'ably/ably-chat-js' && always()
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'ably/ably-chat-js' && matrix.node-version == ${{ env.BASE_NODE_VERSION }} && always()
build:
runs-on: ubuntu-latest
steps:
Expand All @@ -75,7 +82,7 @@ jobs:
submodules: true
- uses: actions/setup-node@v1
with:
node-version: 20
node-version: ${{ env.BASE_NODE_VERSION }}
- run: npm ci
- run: npm run build
demo-app:
Expand All @@ -86,7 +93,7 @@ jobs:
submodules: true
- uses: actions/setup-node@v1
with:
node-version: 20
node-version: ${{ env.BASE_NODE_VERSION }}
- name: npm ci (lib)
run: npm ci
- name: npm build (lib)
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 20.10.0
nodejs 22.13.0
Loading
Loading