-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: dont run docs upload step on forks #466
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File CoverageNo changed files found. |
External contributors can't get a CI green at the moment because the docs upload step requires a secret in Actions that's not available on forked repos. This change makes it so that these steps are skipped on forks, whilst still building the docs to show that they do. This will require a process change for Ablyan reviewers on forked PRs - docs will have to be built and viewed locally, but that's a small price to pay for allowing contributors to get green CI.
0453820
to
b29e024
Compare
Context
Example on this PR: #460
Description
External contributors can't get a CI green at the moment because the docs upload step requires a secret in Actions that's not available on forked repos.
This change makes it so that these steps are skipped on forks, whilst still building the docs to show that they do.
This will require a process change for Ablyan reviewers on forked PRs - docs will have to be built and viewed locally, but that's a small price to pay for allowing contributors to get green CI.