Enforce RTP6c attach rule for presence.

ably · Jul 6, 2024 · 4aea29f · 4aea29f
1 parent d1458ad
commit 4aea29f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/Source/ARTRealtimePresence.m b/Source/ARTRealtimePresence.m
@@ -503,7 +503,9 @@ - (ARTEventListener *)subscribeWithAttachCallback:(ARTCallback)onAttach callback
         if (onAttach) onAttach([ARTErrorInfo createWithCode:ARTErrorChannelOperationFailedInvalidState message:@"attempted to subscribe while channel is in Failed state."]);
         return;
     }
-    [self->_channel _attach:onAttach];
+    if (self->_channel.shouldAttach) { // RTP6c
+        [self->_channel _attach:onAttach];
+    }
     listener = [_eventEmitter on:cb];
     ARTLogVerbose(self.logger, @"R:%p C:%p (%@) presence subscribe to all actions", self->_realtime, self->_channel, self->_channel.name);
 });

diff --git a/Source/PrivateHeaders/Ably/ARTRealtimeChannel+Private.h b/Source/PrivateHeaders/Ably/ARTRealtimeChannel+Private.h
@@ -33,6 +33,7 @@ NS_ASSUME_NONNULL_BEGIN
 - (ARTErrorInfo *)errorReason_nosync;
 - (NSString * _Nullable)clientId_nosync;
 - (BOOL)canBeReattached;
+- (BOOL)shouldAttach;
 
 @property (readonly, weak, nonatomic) ARTRealtimeInternal *realtime; // weak because realtime owns self
 @property (readonly, nonatomic) ARTRestChannelInternal *restChannel;