Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ably-cocoa] Implement no-connection-serial #1494

Closed
jamienewcomb opened this issue Sep 13, 2022 · 1 comment · Fixed by #1714
Closed

[ably-cocoa] Implement no-connection-serial #1494

jamienewcomb opened this issue Sep 13, 2022 · 1 comment · Fixed by #1714
Assignees
@maratal

Comments

@jamienewcomb
Copy link
Member

jamienewcomb commented Sep 13, 2022 •
edited by sync-by-unito bot
Loading

Implement the changes listed in ably/specification#88
Reference impl -> ably/ably-js#1045

┆Issue is synchronized with this Jira Task by Unito
@ikbalkaya ikbalkaya mentioned this issue Sep 14, 2022
Closed
@sync-by-unito sync-by-unito bot assigned maratal and unassigned ikbalkaya Jan 9, 2023
lawrence-forooghian added a commit that referenced this issue Mar 27, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
64ebbc6 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is what one example might look like. It’s based on
spec version 90fb845 ("no-connection-serial"). The intention is that it
form part of our implementation of #1494.
lawrence-forooghian added a commit that referenced this issue Mar 27, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
de26d06 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is what one example might look like. It’s based on
spec version 90fb845 ("no-connection-serial"). The intention is that it
form part of our implementation of #1494.
lawrence-forooghian added a commit that referenced this issue Mar 28, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
9f9e5b6 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is an example of what one might look like. It’s
based on spec version 90fb845 ("no-connection-serial"). The intention is
that it form part of our implementation of #1494.
lawrence-forooghian added a commit that referenced this issue Mar 28, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
50f00ac 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is an example of what one might look like. It’s
based on spec version 90fb845 ("no-connection-serial"). The intention is
that it form part of our implementation of #1494.
lawrence-forooghian added a commit that referenced this issue Mar 28, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
c9997e1 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is an example of what one might look like. It’s
based on spec version 90fb845 ("no-connection-serial"). The intention is
that it form part of our implementation of #1494.
@lawrence-forooghian lawrence-forooghian mentioned this issue Mar 28, 2023
Merged
lawrence-forooghian added a commit that referenced this issue Mar 28, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
1d8696e 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is an example of what one might look like. It’s
based on spec version 90fb845 ("no-connection-serial"). The intention is
that it form part of our implementation of #1494.
lawrence-forooghian added a commit that referenced this issue Mar 28, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
bec091a 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is an example of what one might look like. It’s
based on spec version 90fb845 ("no-connection-serial"). The intention is
that it form part of our implementation of #1494.
lawrence-forooghian added a commit that referenced this issue Mar 28, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
da86be4 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is an example of what one might look like. It’s
based on spec version 90fb845 ("no-connection-serial"). The intention is
that it form part of our implementation of #1494.
lawrence-forooghian added a commit that referenced this issue Mar 29, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
0a1ca25 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is an example of what one might look like. It’s
based on spec version 90fb845 ("no-connection-serial"). The intention is
that it form part of our implementation of #1494.
lawrence-forooghian added a commit that referenced this issue Mar 29, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
71307d7 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is an example of what one might look like. It’s
based on spec version 90fb845 ("no-connection-serial"). The intention is
that it form part of our implementation of #1494.
lawrence-forooghian added a commit that referenced this issue Mar 29, 2023
@lawrence-forooghian
Introduce a ResumeRequestResponse type
ee4773f 
It would be great if we could start writing smaller, unit-testable
pieces of code. This is an example of what one might look like. It’s
based on spec version 90fb845 ("no-connection-serial"). The intention is
that it form part of our implementation of #1494.
@maratal
Copy link
Collaborator

maratal commented May 2, 2023

Jira issue https://ably.atlassian.net/browse/SDK-2636

@maratal maratal mentioned this issue May 21, 2023
Merged
@lawrence-forooghian lawrence-forooghian mentioned this issue May 23, 2023
Open
@sync-by-unito sync-by-unito bot changed the title Implement no-connection-serial [ably-cocoa] Implement no-connection-serial Oct 12, 2023
@coderabbitai coderabbitai bot mentioned this issue Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
None yet
Milestone
No milestone
3 participants
@ikbalkaya @maratal @jamienewcomb