Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initializers from ART{Rest, Realtime}Protocol #2019

Open
lawrence-forooghian opened this issue Jan 28, 2025 · 0 comments
Open

Remove initializers from ART{Rest, Realtime}Protocol #2019

lawrence-forooghian opened this issue Jan 28, 2025 · 0 comments
Labels
breaking Backwards incompatible changes made to the public API.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Jan 28, 2025

In 1b127e2 I wanted to remove the initializers from these protocols but couldn't due to backwards compatibility, so instead had to introduce intermediate protocols ART{Rest, Realtime}InstanceMethodsProtocol. In our next major release, remove these intermediate protocols and remove the initializers from the protocols.

┆Issue is synchronized with this Jira Task by Unito

@lawrence-forooghian lawrence-forooghian added the breaking Backwards incompatible changes made to the public API. label Jan 28, 2025
lawrence-forooghian added a commit that referenced this issue Jan 29, 2025
Preparation for introducing a new class that conforms to these protocols
but which won't have these initializers. Let's use these protocols just
to list the functionality provided by an already-initialized client.

(To do this in a backwards-compatible way I've had to not actually
remove anything from the existing protocols, but rather introduce new
ones, which is a bit messy. Have created #2019 for us to sort this out
in our next major release.)
lawrence-forooghian added a commit that referenced this issue Jan 30, 2025
Preparation for introducing a new class that conforms to these protocols
but which won't have these initializers. Let's use these protocols just
to list the functionality provided by an already-initialized client.

(To do this in a backwards-compatible way I've had to not actually
remove anything from the existing protocols, but rather introduce new
ones, which is a bit messy. Have created #2019 for us to sort this out
in our next major release.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Backwards incompatible changes made to the public API.
Development

No branches or pull requests

1 participant