Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library doesn't follow RTN14d #2023

Open
maratal opened this issue Feb 1, 2025 · 0 comments
Open

Library doesn't follow RTN14d #2023

maratal opened this issue Feb 1, 2025 · 0 comments
Assignees
@maratal
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@maratal
Copy link
Collaborator

maratal commented Feb 1, 2025 •
edited
Loading

I'm curious why this test was failing? Shouldn't the connection become DISCONNECTED per RTN14d?

Originally posted by @lawrence-forooghian in #2017 (comment)

Library reconnects without going DISCONNECTED first which is in contradiction with RTN14d:

If a connection attempt fails for any recoverable reason (i.e. a network failure, a timeout such as RTN14c, or a disconnected response, other than a token failure RTN14b), the Connection#state will transition to DISCONNECTED

┆Issue is synchronized with this Jira Task by Unito
maratal added a commit that referenced this issue Feb 1, 2025
@maratal
This test wasn't failing because of a bug fixed in the previous commi…
31ef48b 
…t. See #2023
@maratal maratal mentioned this issue Feb 1, 2025
Merged
maratal added a commit that referenced this issue Feb 2, 2025
@maratal
This test wasn't failing because of a bug fixed in the previous commi…
f62d6ea 
…t. See #2023
@maratal maratal self-assigned this Feb 2, 2025
@maratal maratal added the bug Something isn't working. It's clear that this does need to be fixed. label Feb 2, 2025
maratal added a commit that referenced this issue Feb 4, 2025
@maratal
This test wasn't failing because the old host check in `realtimeTrans…
5a232f4 
…portFailed:` (an exact string) wasn't allowing it to start reconnecting (it uses "sandbox" by default). Since now the environment is omitted in this check (to sandbox to work in similar way as production), it now tries to reconnect with fallbacks and doing so it isn't going disconnect first. This is a bug, so I've skipped this test for this PR, issue - #2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maratal