Should not wait for AblyTest.options in 'context' scope #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ricardopereira
commented
Jun 5, 2020
ricardopereira
commented
- For example, if you run a solo test where you don't need internet connection, then the test will fail because there are AblyTest.commonAppSetup() calls inside of 'context' scopes which are executed even if you select only one test to run.
- For example, if you run a solo test where you don't need internet connection, then the test will fail because there are AblyTest.commonAppSetup() calls inside of 'context' scopes which are executed even if you select only one test to run.
QuintinWillison
previously approved these changes
Jun 10, 2020
Co-authored-by: Quintin <[email protected]>
QuintinWillison
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.