Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Push State Machine delegate syncing the main queue #1064

Merged
merged 7 commits into from
Oct 6, 2020
Merged

Fix Push State Machine delegate syncing the main queue #1064

merged 7 commits into from
Oct 6, 2020

Conversation

ricardopereira
Copy link
Contributor

@ricardopereira ricardopereira commented Jul 31, 2020 •
edited by QuintinWillison
Loading

Fixes #1029.

@ricardopereira ricardopereira force-pushed the fix-push-state-machine-main-queue-sync branch from caed5a0 to a7e11a2 Compare August 20, 2020 14:40
@ricardopereira
Copy link
Contributor Author

Screenshot 2020-08-20 at 15 35 45

@QuintinWillison QuintinWillison changed the base branch from main to remove-SAMKeychain-dep October 5, 2020 14:36
@QuintinWillison QuintinWillison force-pushed the fix-push-state-machine-main-queue-sync branch from a7e11a2 to ecf83bf Compare October 5, 2020 14:36
@QuintinWillison QuintinWillison self-assigned this Oct 5, 2020
Base automatically changed from remove-SAMKeychain-dep to main October 6, 2020 08:35
@ricardopereira
Push: retrieve the application delegate from the main queue without
f7030ca 
blocking the main queue. NSThread.isMainThread doesn't mean we are in
the main queue and in general Apple doesn't recommend do sync calls to
the main queue.
@ricardopereira
Avoiding passing self-> and create an internal method instead.
c6fe33f
@ricardopereira
Update push tests.
8e80191
@QuintinWillison QuintinWillison force-pushed the fix-push-state-machine-main-queue-sync branch from ecf83bf to 8e80191 Compare October 6, 2020 08:38
QuintinWillison
QuintinWillison approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I would say that. 😝

@QuintinWillison QuintinWillison merged commit 1d0d4df into main Oct 6, 2020
@QuintinWillison QuintinWillison deleted the fix-push-state-machine-main-queue-sync branch October 6, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

Assignees

@QuintinWillison QuintinWillison

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock getting ARTRealtimeChannel between two dispatch_sync (ui queue vs ably main queue)
2 participants
@ricardopereira @QuintinWillison