Remove SAMKeychain dependency and use internal solution #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to #949 |
|
This is great! I'm actually in the middle of migrating dependencies for Tuple right now and these changes would be super handy. Looking forward to getting this downstream 👍 |
QuintinWillison
changed the base branch from
travis-update-xcode
to
feature/remove-kscrash
QuintinWillison
force-pushed
the
remove-SAMKeychain-dep
branch
from
2b5b1eb to
03494b7
Compare
|
Hmm, some to unpick here. I hoped this would be simple but @ricardopereira had forked from his Travis PR which is still in Draft. I'm going to rebase to remove the conflating commits, as I believe the SAMKeychain removal piece is pretty self-contained. |
QuintinWillison
force-pushed
the
remove-SAMKeychain-dep
branch
from
03494b7 to
6783968
Compare
|
That's better. Essence restored. Sorry for the noise, @paddybyers and @tcard, but all good for review now. 😁 |
paddybyers
approved these changes
Oct 5, 2020
QuintinWillison
approved these changes
Oct 6, 2020
tcard
reviewed
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAMKeychain has been archived and not maintained anymore #897.