Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending ErrorInfo with href and requestId #1147

Merged
merged 15 commits into from
Jul 23, 2021

Conversation

lukasz-szyszkowski
Copy link
Contributor

No description provided.

Add requestId to ErrorInfo, for requests with addRequestId flag
Source/ARTNSError+ARTUtils.m Show resolved Hide resolved
Source/ARTRest+Private.h Show resolved Hide resolved
Source/ARTStatus.m Show resolved Hide resolved
@maratal
Copy link
Collaborator

maratal commented Jul 5, 2021

Please link an issue if it exists.

@lukasz-szyszkowski lukasz-szyszkowski linked an issue Jul 6, 2021 that may be closed by this pull request
@lukasz-szyszkowski
Copy link
Contributor Author

Please link an issue if it exists.

linked

Spec/RestClient.swift Outdated Show resolved Hide resolved
Source/ARTNSError+ARTUtils.m Show resolved Hide resolved
Source/ARTNSMutableURLRequest+ARTUtils.m Show resolved Hide resolved
Source/ARTRest.m Show resolved Hide resolved
Source/ARTRest.m Show resolved Hide resolved
Source/ARTRest.m Show resolved Hide resolved
Source/ARTRestChannel.m Show resolved Hide resolved
@lukasz-szyszkowski
Copy link
Contributor Author

lukasz-szyszkowski commented Jul 23, 2021

image
since one of two iOS tests are passed and the rest of them are green, it's qualified to merge to main.

@lukasz-szyszkowski lukasz-szyszkowski merged commit 4f1bfeb into main Jul 23, 2021
@lukasz-szyszkowski lukasz-szyszkowski deleted the feature/ErrorInfo-urls branch July 23, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Implement ErrorInfo URLs to help debug issues
3 participants