Blocks typedef #1166
Merged
Blocks typedef #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuintinWillison
suggested changes
Aug 26, 2021
There was a problem hiding this comment.
This build failure looks related so should be something you can fix.
lukasz-szyszkowski
approved these changes
Aug 27, 2021
|
@QuintinWillison Fixed e3e07c4 |
QuintinWillison
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided not to typedef short blocks like
void(^)(void)since a name for this block will take more characters then the block itself. Also there are many variations of it likeid(^)(void)or something, that it will become a mess on its own. Closes #1032