Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Xcodebuild Logs uploading step #1192

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Added Xcodebuild Logs uploading step #1192

merged 1 commit into from
Oct 20, 2021

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Oct 20, 2021

No description provided.

QuintinWillison
QuintinWillison approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible and has got to be better than where we were before. I've not looked at what's being collected or how it's presented (all I do know is that artifacts always have to present as a ZIP file, because GitHub made them that way).

@maratal maratal merged commit cbdbcb6 into main Oct 20, 2021
@maratal maratal deleted the xcode-build-test-logs-upload branch October 20, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawrence-forooghian lawrence-forooghian lawrence-forooghian approved these changes

@lukasz-szyszkowski lukasz-szyszkowski lukasz-szyszkowski approved these changes

@QuintinWillison QuintinWillison QuintinWillison approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maratal @QuintinWillison @lukasz-szyszkowski @lawrence-forooghian