When setting realtime channel options, pass through to REST channel #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to handle arguments that don’t support NSCopying. I assume the original intention was to return something to the caller that couldn’t be mutated under their feet, but I think I’d expect a spy method like this to accurately report the exact instance that was received.
When calling -[ARTRealtimeChannel setOptions:callback:], the passed options are not used to update the options of this instance’s REST channel. This means that, for example, if we update the realtime channel’s cipher options, these options will not be used to decrypt messages subsequently fetched using the -history:* methods. I think this is something we missed when fixing #1207 (34d68ec). This issue is causing ably/ably-flutter#296. Closes #1265.
lawrence-forooghian
force-pushed
the
1265-updating-rest-channel-options-should-update-underlying-rest-channel
branch
from
c4f4f20 to
71250a0
Compare
lawrence-forooghian
requested review from
ikbalkaya,
lukasz-szyszkowski and
QuintinWillison
maratal
approved these changes
Jan 19, 2022
lukasz-szyszkowski
approved these changes
Jan 20, 2022
ikbalkaya
approved these changes
Jan 20, 2022
QuintinWillison
approved these changes
Jan 20, 2022
QuintinWillison
deleted the
1265-updating-rest-channel-options-should-update-underlying-rest-channel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
-[ARTRealtimeChannel setOptions:callback:], the passed options are not used to update the options of this instance’s REST channel. This means that, for example, if we update the realtime channel’s cipher options, these options will not be used to decrypt messages subsequently fetched using the-history:*methods.I think this is something we missed when fixing #1207.
This issue is causing ably/ably-flutter#296.
Closes #1265.