Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to the registerForRemoteNotifications #1293

Merged
merged 10 commits into from
Apr 15, 2022
Merged

Call to the registerForRemoteNotifications #1293

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
afa4d59
New API to request/register/activate APN service. Compatible with the…
maratal Feb 28, 2022
c902f64
Revert "New API to request/register/activate APN service. Compatible …
maratal Mar 4, 2022
a47ef44
Incorporating the call to registerForRemoteNotifications/unregisterFo…
maratal Mar 6, 2022
b809372
Force `registerForRemoteNotifications` to be called on the main thread
maratal Mar 11, 2022
a9e92de
Check if already on the main thread
maratal Mar 17, 2022
44a7e20
Merge remote-tracking branch 'origin/main' into feature/1271-call-to-…
maratal Mar 25, 2022
d959b7b
Removed call to `unregisterForRemoteNotifications`
maratal Mar 25, 2022
01b448f
Moved `registerForRemoteNotifications` to `ARTPushActivationStateNotA…
maratal Mar 27, 2022
3cece2e
Test for `registerForRemoteNotifications` is being called
maratal Mar 27, 2022
baa71f7
Removed unnecessary check for main thread
maratal Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Source/ARTPush.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,22 @@ + (void)didFailToRegisterForRemoteNotificationsWithError:(NSError *)error rest:(
}

- (void)activate {
#if TARGET_OS_IOS && !TARGET_OS_SIMULATOR
dispatch_async(dispatch_get_main_queue(), ^{
lukasz-szyszkowski marked this conversation as resolved.
Show resolved Hide resolved
[[UIApplication sharedApplication] registerForRemoteNotifications];
});
#endif
[self getActivationMachine:^(ARTPushActivationStateMachine *stateMachine) {
[stateMachine sendEvent:[ARTPushActivationEventCalledActivate new]];
}];
}

- (void)deactivate {
#if TARGET_OS_IOS && !TARGET_OS_SIMULATOR
dispatch_async(dispatch_get_main_queue(), ^{
[[UIApplication sharedApplication] unregisterForRemoteNotifications];
lawrence-forooghian marked this conversation as resolved.
Show resolved Hide resolved
});
#endif
[self getActivationMachine:^(ARTPushActivationStateMachine *stateMachine) {
[stateMachine sendEvent:[ARTPushActivationEventCalledDeactivate new]];
}];
Expand Down