Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTN7c #154

Merged
merged 4 commits into from
Jan 29, 2016
Merged

RTN7c #154

merged 4 commits into from
Jan 29, 2016

Conversation

ricardopereira
Copy link
Contributor

Need fix.

@ricardopereira
Copy link
Contributor Author

Tests are failing because of:

  • published a message (the connection gets closed) and the callback isn't called.
  • published a message (the connection gets a failure) and the callback isn't called.

@tcard
Copy link
Contributor

tcard commented Jan 21, 2016

Test looks good. I guess it's an internal problem.

@ricardopereira
Copy link
Contributor Author

I think that too.

@mattheworiordan
Copy link
Member

This needs rebasing unfortunately, can you do that before I review & merge?

@ricardopereira ricardopereira force-pushed the RTN7c branch 2 times, most recently from cf7ee1e to 75d50ce Compare January 26, 2016 09:20
mattheworiordan
mattheworiordan reviewed Jan 26, 2016
View reviewed changes
ablySpec/RealtimeClient.connection.swift
}

// RTN7c
context("should deliver as failed the remaining pending messages if") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the wording here should be "should trigger the failure callback for the remaining pending messages if"

@ricardopereira ricardopereira force-pushed the RTN7c branch 2 times, most recently from d432739 to 30f8249 Compare January 28, 2016 12:58
@ricardopereira
Copy link
Contributor Author

Rebased with changes.

@mattheworiordan
Copy link
Member

LGTM

1 similar comment
@tcard
Copy link
Contributor

tcard commented Jan 29, 2016

LGTM

ricardopereira added a commit that referenced this pull request Jan 29, 2016
@ricardopereira
Merge pull request #154 from ably/RTN7c
232f398 
RTN7c
@ricardopereira ricardopereira merged commit 232f398 into master Jan 29, 2016
@ricardopereira ricardopereira deleted the RTN7c branch January 30, 2016 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardopereira @tcard @mattheworiordan