RTL6a

[ricardopereira]

No description provided.

[ricardopereira]

I'm getting errors after the #171:

2016-02-04 18:50:15.161 xctest[85089:13705808] ERROR: ARTDataDecoded failed to decode data as 'json': (__NSCFDictionary){
    value = 1;
}
2016-02-04 18:50:15.162 xctest[85089:13705808] ERROR: ARTRealtimeChannel: error decoding data, status: 2038569904

@tcard Any thoughts?

[ricardopereira]

I can debug it later.

[tcard]

@ricardopereira Seems like it's trying to decode a piece of JSON that is already decoded. The data of the incoming message should be a string, not a dictionary.

[ricardopereira]

The test is publishing a dictionary. The existing RSL4d4 test is also failing:

2016-02-04 19:03:17.233 xctest[85570:13716774] ERROR: ARTDataDecoded failed to decode data as 'json': (__NSCFArray)(
    John,
    Mary
)
2016-02-04 19:03:17.233 xctest[85570:13716774] ERROR: ARTDataDecoded failed to decode data as 'json': (__NSCFDictionary){
    name = John;
    number = 3;
}

@tcard Should I open an issue?

[tcard]

@ricardopereira Please.

[tcard]

I'm not sure how this aspects thing works, but if message here is the original, unencoded message that is passed to encodeMessageIfNeeded, take into account that ARTMessage.encode returns a copy of the ARTMessage instance, and thus this message won't be mutated by invocation.invoke(), and you're assigning the unencoded version to restEncodedMessage.

Ignore this if this message is what's returned by encodeMessageIfNeeded. (But then I don't understand what invocation.invoke() is invoking.)

[ricardopereira]

invocation.invoke() calls the original implementation, so the encodeWithEncoder will write to the current ARTMessage instance (look https://github.com/ably/ably-ios/blob/bff8f901b67e9ab12b38fa477470ed773ae0a902/ably-ios/ARTChannel.m#L54). Even so, I saw the documentation and I think it is possible to retrieve the original return value of the mehotd directly with the NSInvocation.getReturnValue. I think both approaches are correct. What you think?

[tcard]

That link shows how encodeWithEncoder takes an output argument, where it writes the new message, which is then a different instance than the message passed as argument to encodeMessageIfNeeded, ie. the message in this block. For this to be correct you need to use the returned message.

[ricardopereira]

Yes, you right, It is doing a copy of the message. I will try to use the NSInvocation.getReturnValue. Ty.

[ricardopereira]

Fixed 357c5db.

[mattheworiordan]

Ok, looks good to me

[tcard]

LGTM