Release version 1.2.39 #2032
Release version 1.2.39 #2032
Conversation
WalkthroughThis pull request updates the version of the project from 1.2.38 to 1.2.39. The changes span documentation updates in the changelog, README, and configuration files, as well as version bumps in source code and test assertions. Bug fixes and improvements are briefly outlined in the changelog, and the expected version strings in various tests have been updated to ensure consistency with the new release. Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
15-16: Full Changelog URL Presentation
The final entry, "Full Changelog: 1.2.38...1.2.39", correctly provides a link comparing the previous version with the current release.
Note:
Static analysis (MD034) flags the use of a bare URL. While it is common in changelogs to display URLs in this manner, you might consider wrapping the URL in angle brackets (i.e.<https://...>) to satisfy markdownlint rules if needed.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
15-15: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
CHANGELOG.md(1 hunks)README.md(2 hunks)Scripts/jazzy.sh(1 hunks)Source/ARTClientInformation.m(1 hunks)Test/Tests/ARTDefaultTests.swift(1 hunks)Test/Tests/ClientInformationTests.swift(3 hunks)Test/Tests/RealtimeClientConnectionTests.swift(1 hunks)Test/Tests/RestClientTests.swift(1 hunks)Test/Tests/WrapperSDKProxyTests.swift(3 hunks)Version.xcconfig(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- Version.xcconfig
- Scripts/jazzy.sh
- Test/Tests/ARTDefaultTests.swift
- Source/ARTClientInformation.m
- Test/Tests/WrapperSDKProxyTests.swift
- README.md
- Test/Tests/RealtimeClientConnectionTests.swift
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
9-9: Bare URL used
null
(MD034, no-bare-urls)
13-13: Bare URL used
null
(MD034, no-bare-urls)
15-15: Bare URL used
null
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: check (macOS, test_macOS)
- GitHub Check: check (tvOS, test_tvOS17_2)
- GitHub Check: check
- GitHub Check: build
- GitHub Check: check
- GitHub Check: check (iOS, test_iOS17_2)
🔇 Additional comments (6)
Test/Tests/ClientInformationTests.swift (1)
12-12: LGTM! Version updates are consistent.The version string updates from "1.2.38" to "1.2.39" in test assertions are consistent with the PR objectives.
Also applies to: 30-30, 45-45
Test/Tests/RestClientTests.swift (1)
1739-1739: LGTM! Version update is consistent.The version string update from "1.2.38" to "1.2.39" in the test assertion is consistent with the PR objectives.
CHANGELOG.md (4)
3-4: New Version Entry Added
The changelog entry for version 1.2.39 is clearly introduced with a hyperlink to the corresponding branch in the repository. Please double-check that the link is correct and reflects the intended release branch.
5-6: Section Title for Changes Overview
The "### What's Changed" header is correctly placed and clearly signals the start of the changes for this release. No further modifications are needed here.
7-10: Bug Fixes Entry Clarity
Under the "#### Bug fixes" subsection, the bullet point reads:
"* Fix bug where fallback hosts were not working correctly in custom environments (#2017)".
This entry is concise and includes a reference to the responsible pull request. The description is clear.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
9-9: Bare URL used
null(MD034, no-bare-urls)
11-14: Other Changes Entry Documentation
The "#### Other changes" section includes the bullet:
"* Improvements to the Ably-internal API introduced in v1.2.38 (#2031)".
This is well-documented and links to further details. If additional context becomes necessary later, consider elaborating; otherwise, the current level of detail is sufficient.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
13-13: Bare URL used
null(MD034, no-bare-urls)
|
Test failures unrelated to these changes, merging. |
Summary by CodeRabbit