RTL7e #211
RTL7e #211
Conversation
ricardopereira
force-pushed
the
RTL7e
branch
from
632712e to
f7d67b2
Compare
|
Rebased with changes. |
| let line = logs.reduce("") { $0 + "; " + $1 } //Reduce in one line | ||
| expect(line).to(contain("ERROR: ARTDataDecoded failed to decode data as 'invalid'")) | ||
|
|
||
| done() |
There was a problem hiding this comment.
Same as #209 (comment):
Not tested: "an ErrorInfo error object is emitted as an error on the Channel". (I guess this means that the error is set in RealtimeChannel.errorReason.)
Although now I think "an error should be emitted on the channel" means that it should be emitted to the channel.on listeners. @mattheworiordan is this right? Should it also be set in RealtimeChannel.errorReason?
There was a problem hiding this comment.
Yes, ideally we want to have a generic on('error') handler, although this is not fully supported in all libs unfortunately. Yes, Channel.errorReason should be set as well.
ricardopereira
force-pushed
the
RTL7e
branch
2 times, most recently
from
813f30f to
ead24be
Compare
|
Done |
|
This should be rebased on top of #231 once it's merged. |
|
I am assuming this is somewhat blocked by ably/docs#89 (comment) so we can review once that is finalised and merged in? |
|
Correct. |
|
@ricardopereira #231 is merged, you can rebase this now. |
ricardopereira
force-pushed
the
RTL7e
branch
from
3b256bc to
e1cc273
Compare
|
Rebased with changes: e1cc273. |
|
LGTM |
1 similar comment
|
LGTM |
✅
Picked: 4b6829d.