RTN15g #250
RTN15g #250
Conversation
|
I think this should be rebased with #228 fixes. |
|
|
||
| client.simulateResumeFailure() | ||
|
|
||
| expect(channel.state).toEventually(equal(ARTRealtimeChannelState.Detached), timeout: testTimeout) |
There was a problem hiding this comment.
Shouldn't this be waiting for a Failed state and not a Detached state?
There was a problem hiding this comment.
Isn't suppose to only detach the channel?
ricardopereira
force-pushed
the
RTN15g
branch
from
79d60de to
2548600
Compare
|
Rebased with master and removed |
| channel.attach() | ||
| expect(channel.state).toEventually(equal(ARTRealtimeChannelState.Attached), timeout: testTimeout) | ||
|
|
||
| channel.on(.Failed) { errorInfo in |
There was a problem hiding this comment.
Why are you checking on(Failed), this should not happen when a connection resume has failed, the channel goes to a detached state.
There was a problem hiding this comment.
More generally, every test that uses callbacks should make sure that the callback is being called. Please add that as well.
There was a problem hiding this comment.
Right, on(Failed) does nothing in the test.
There was a problem hiding this comment.
Done ea4a06e.
|
@ricardopereira #231 is merged, you can rebase this now. |
|
@ricardopereira are you going to rebase this one? |
|
Yes. |
ricardopereira
force-pushed
the
RTN15g
branch
2 times, most recently
from
e292112 to
ac0306d
Compare
No description provided.