RSL1g4 #362
RSL1g4 #362
Conversation
|
The only issue I can see is that there is no way to be sure that the test is not rejecting the message because the server is rejecting it, or as intended by the spec, the client lib is rejecting it. Can you somehow ensure that the message is never sent to the server i.e. rejected before that happens? |
|
@mattheworiordan @tcard PTAL. |
| case .Failure(let error): | ||
| fail(error) | ||
| case .Success(let rawMessages): | ||
| expect(rawMessages.unbox.first!["clientId"] as? String).to(equal("tester")) |
There was a problem hiding this comment.
I'm not sure I get this. The spec says that the library should catch the error, so the request this block is intercepting shouldn't happen, isn't that right?
There was a problem hiding this comment.
To clarify, the library should catch the error before sending the request, thus failing early and preventing it from happening.
There was a problem hiding this comment.
Yes, you right. The request shouldn't happen. Fixed 436b265.
|
@tcard PTAL |
|
LGTM, but isn't this doing exactly the same as #361 ? |
|
Quite but RSL1g3 is checking if the connection and channel remains active. |
* RSL1g4 * Test suite: MockHTTPExecutor can ignore the http request - added `beforeRequest` event * Fix RSL1g4: should reject the clientId before the message is sent to the server * RSL1g4: pending * TestSuite: injectIntoMethodBefore * Reject the message immediately if the clientId doesn't match * Fix RSL1g4
No description provided.