WebSocket: remove ARTWsAbnormalClose (1006) #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "1006 is a reserved value and MUST NOT be set as a status code in a Close control frame by an endpoint". See https://tools.ietf.org/html/rfc6455 page 45.
|
Looks good to me. @SimonWoolf? |
|
👍 |
|
Anything holding up this getting merged & released? |
|
@SimonWoolf Tests aren't passing. Let me just take a look at what's happening. |
|
any luck? We have a customer who's been waiting for this for a couple weeks, would be nice to get back to them |
|
@SimonWoolf We can merge this. I created another branch for the test suite #609. |
tcard
pushed a commit
that referenced
this pull request
May 31, 2017
- "1006 is a reserved value and MUST NOT be set as a status code in a Close control frame by an endpoint". See https://tools.ietf.org/html/rfc6455 page 45.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#605