Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to DISCONNECTED on unexpected WebSocket close. #656

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Nov 30, 2017

Should fix #655.

@tcard
Copy link
Contributor Author

tcard commented Nov 30, 2017

@ricardopereira I can't run the test suite anymore.

Showing Recent Messages
CompileC /Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/Objects-normal/x86_64/ARTRest.o Source/ARTRest.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
    cd /Users/tcard/golang/src/github.com/ably/ably-ios
    export LANG=en_US.US-ASCII
    export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu99 -fobjc-arc -fmodules -gmodules -fmodules-cache-path=/Users/tcard/Library/Developer/Xcode/DerivedData/ModuleCache -fmodules-prune-interval=86400 -fmodules-prune-after=345600 -fbuild-session-file=/Users/tcard/Library/Developer/Xcode/DerivedData/ModuleCache/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror=non-modular-include-in-framework-module -Xclang -fmodule-implementation-of -Xclang Ably -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wunreachable-code -Wno-implicit-atomic-properties -Werror=deprecated-objc-isa-usage -Werror=objc-root-class -Wno-arc-repeated-use-of-weak -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wno-deprecated-implementations -DDEBUG=1 -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.3.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -mios-simulator-version-min=8.0 -g -Wno-sign-conversion -Winfinite-recursion -fobjc-abi-version=2 -fobjc-legacy-dispatch -iquote /Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/Ably-generated-files.hmap -I/Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/Ably-own-target-headers.hmap -I/Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/Ably-all-non-framework-target-headers.hmap -ivfsoverlay /Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/all-product-headers.yaml -iquote /Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/Ably-project-headers.hmap -I/Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Products/Debug-iphonesimulator/include -I/Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/DerivedSources/x86_64 -I/Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/DerivedSources -F/Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Products/Debug-iphonesimulator -F/Users/tcard/golang/src/github.com/ably/ably-ios/Carthage/Build/iOS -MMD -MT dependencies -MF /Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/Objects-normal/x86_64/ARTRest.d --serialize-diagnostics /Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/Objects-normal/x86_64/ARTRest.dia -c /Users/tcard/golang/src/github.com/ably/ably-ios/Source/ARTRest.m -o /Users/tcard/Library/Developer/Xcode/DerivedData/Ably-bkzaqierndrdrshgwkeoexgrbipr/Build/Intermediates/Ably.build/Debug-iphonesimulator/Ably.build/Objects-normal/x86_64/ARTRest.o

/Users/tcard/golang/src/github.com/ably/ably-ios/Source/ARTRest.m:44:9: fatal error: 'KSCrash/KSCrash.h' file not found
#import <KSCrash/KSCrash.h>
        ^
1 error generated.

I guess this is due to the latest Carthage+Cocoapods fixes.

Also, I've noticed that pod install doesn't install all dependencies now:

Analyzing dependencies
Downloading dependencies
Using Aspects (1.4.1)
Using Nimble (7.0.0)
Using Quick (1.1.0)
Using SwiftyJSON (3.1.4)
Generating Pods project
Integrating client project
Sending stats
Pod installation complete! There are 4 dependencies from the Podfile and 4 total pods installed.

Those are the test dependencies only. What about KSCrash, msgpack, etc.?

@ricardopereira
Copy link
Contributor

@tcard You might need to run carthage bootstrap. Please check

@ricardopereira
Copy link
Contributor

I improved the README #658

@tcard tcard changed the title WIP: Move to DISCONNECTED on unexpected WebSocket close. Move to DISCONNECTED on unexpected WebSocket close. Dec 1, 2017
@tcard
Copy link
Contributor Author

tcard commented Dec 1, 2017

Thanks @ricardopereira, that did the trick.

@tcard tcard merged commit f5fc053 into master Dec 1, 2017
@ricardopereira ricardopereira deleted the 655-ws-close branch January 12, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants