Swift 4: upgrade settings and dependencies #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ricardopereira Take a look at the failures. Might help to come up with an estimate for the upgrade. |
Compilation was failing due to this: https://travis-ci.org/ably/ably-ios/builds/334047803
|
@ricardopereira ready for review once everything is green. |
ricardopereira
changed the title
ricardopereira
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ricardopereira We need an estimate of the complexity of migrating to the newest version Xcode, Swift 4 and possibly also upgrading Nimble and Quick.
I created this branch from master just to have a playground and see which are the obstacles.
cc @paddybyers