Push missing tests #722
Merged
Push missing tests #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why isn't this PR running tests?! |
funkyboy
approved these changes
Jun 12, 2018
| waitUntil(timeout: testTimeout) { done in | ||
| rest.push.activationMachine().transitions = { event, _, _ in | ||
| if event is ARTPushActivationEventGotPushDeviceDetails { | ||
| done() |
There was a problem hiding this comment.
Would be nice to test if the details passed to didRegisterForRemoteNotifications match those handled by this callback.
funkyboy
force-pushed
the
push-missing-tests
branch
from
b967955 to
c771d2d
Compare
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.