Merge push into develop #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARTPushNotifications interface Realtime: integrate Push type Rest: integrate Push type Push.activate Push.publish - add PushRecipient protocol PushChannel subscribe and unsubscribe Fix registerCallback Remove warnings - unused methods Fix FormFactor Fix: use device token as Hex string Fix: should respect the default encoder - useBinaryProtocol Remove ARTPushRecipient protocol and types Add ULID pod Use ULID as DeviceId Push.deactivate Load local device Push: update device PushChannel.subscriptions Update ULID pod PushAdmin Update ULID pod Remove warnings JSON encoder: normalize deviceToken hex string Fix: Push.publish request body Update device forms Activation State Machine: init Activation State Machine: registration Removed ablyPushAuthKey, ablyPushAuthToken and ablyPushClientId from push delegate Add Rest argument on Push delegate Fix things for push, and adapt to latest API. Push: add registering delegate methods for Realtime too. Add new private headers to modulemap. Fix rebase merge conflicts. Recalculate Podfile.lock checksum.
With a static method, the constructed class is always the parent abstract class ARTPushActivationState, instead of the desired child class. Fixes #628.
* MockHTTPExecutor * PushAdmin * Move `publish` method to Admin * Add `get` method in PushDeviceRegistrations * Should use response encoder type * Fix save channel subscription * Fix save device registration * Better errors information * Rename publish notification argument to data to conform specs * Add equatable to DeviceDetails * Fix DeviceRegistrations.get * Add validations to PushAdmin.publish * Fix RHS1a * Fix RHS1b1 * Fix PushAdmin implementation * Fix ambiguous reference to member 'dataTask(with:completionHandler:)' * fixup! Fix PushAdmin implementation * CI test * fixup! Fix PushAdmin implementation
* Initial Push types * Update project * ARTPushNotifications interface * Realtime: integrate Push type * Rest: integrate Push type * Push.activate * fixup! Push.activate * Push.publish - add PushRecipient protocol * fixup! Push.publish * PushChannel subscribe and unsubscribe * Fix registerCallback * Remove warnings - unused methods * Fix FormFactor * Fix: use device token as Hex string * Fix: should respect the default encoder - useBinaryProtocol * Remove ARTPushRecipient protocol and types * Add ULID pod * Use ULID as DeviceId * Push.deactivate * Load local device * Push: update device * PushChannel.subscriptions * Update ULID pod * PushAdmin * Update ULID pod * Remove warnings * JSON encoder: normalize deviceToken hex string * Fix: Push.publish request body * Update device forms * Activation State Machine: init * Activation State Machine: registration * Removed ablyPushAuthKey, ablyPushAuthToken and ablyPushClientId from push delegate * Add Rest argument on Push delegate * tmp * Fix things for push, and adapt to latest API. * Initial State Machine tests * ARTLocalDeviceStorage * Fix: ARTPushActivationState * Storage should synchronize UserDefaults * Storage Keys accessible on tests * State Machine tests * ActivationStateMachine: custom delegate and other fixes * PushActivationStateMachine * Implement Device storage * Fix headers * Fix tests
- it replaces the Device UpdateToken
- LocalDevice is shared in different Rest instances because of the dispatch_once. The initial Rest instance could be released and the LocalDevice would be using an invalid Rest object.
…d ARTPushRegistererDelegate
ricardopereira
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.