Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RTN14b test #791

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Improve RTN14b test #791

merged 2 commits into from
Sep 6, 2018

Conversation

funkyboy
Copy link
Contributor

@funkyboy funkyboy commented Sep 5, 2018

No description provided.

expect(reason.code) == 40142
expect(reason.code).to(equal(40142))
expect(reason.statusCode).to(equal(401))
expect(stateChange!.reason!.message).to(contain("Key/token status changed (expire)"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace stateChange!.reason!.message with reason.message?

Copy link
Contributor

@ricardopereira ricardopereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment. Thanks! 👍

@funkyboy
Copy link
Contributor Author

funkyboy commented Sep 6, 2018

@ricardopereira makes a lot of sense :)
Here you go: a6d9ee7#diff-8c3eccfb7635c28b9fadd0e4fcb6e6b0R1996

Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@funkyboy funkyboy merged commit 1b21b30 into develop Sep 6, 2018
@funkyboy funkyboy deleted the improve-RTN14b branch September 6, 2018 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants