Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac support #817

Merged
merged 33 commits into from
Dec 20, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
ef00b1e
Add macOS and tvOS targets and schemes
ricardopereira Nov 9, 2018
7a29f2c
[fix] Misuse of #ifdef for preprocessor macros
ricardopereira Nov 9, 2018
28ee66e
[fix] Device Form Factor for macOS
ricardopereira Nov 9, 2018
229d0ae
kSecAttrAccessibleWhenUnlocked not available in macOS
ricardopereira Nov 9, 2018
da53b71
Share macOS and tvOS schemes
ricardopereira Nov 9, 2018
863b8d0
Device should not be available in macOS
ricardopereira Nov 9, 2018
d6d51c0
Add CompatibilityMacros.h to macOS and tvOS
ricardopereira Nov 9, 2018
bedf4df
Check internet connection using SSL
ricardopereira Nov 10, 2018
3f1f046
Headers that should be private
ricardopereira Nov 10, 2018
8795506
Update dependencies
ricardopereira Nov 13, 2018
2e5e534
[fix] Umbrella header does not include header 'ARTPushChannel.h'
ricardopereira Nov 15, 2018
f4c9edd
ARTNSDate+ARTUtil.h should be private
ricardopereira Nov 15, 2018
1a48ec5
Remove warnings in iOS test target
ricardopereira Nov 15, 2018
745488f
Remove old folders and uniformize the Info.plist file names
ricardopereira Nov 15, 2018
74da67f
Private Cartfile
ricardopereira Nov 16, 2018
681decb
Add macOS Test Target
ricardopereira Nov 16, 2018
d13f252
macOS Tests (experiment)
ricardopereira Nov 16, 2018
c9b1114
Add tvOS Test Target
ricardopereira Nov 16, 2018
b6667ff
MockDeviceStorage should only available in iOS
ricardopereira Nov 16, 2018
5a1b7e5
Swift Test Targets doesn't use the TargetConditionals
ricardopereira Nov 16, 2018
0df7839
macOS: implement NSSystemClockDidChangeNotification for significant t…
ricardopereira Nov 16, 2018
75fca73
macOS: fix warnings about deprecated methods
ricardopereira Nov 16, 2018
d1be913
iOS: fix warnings about deprecated methods
ricardopereira Nov 16, 2018
e59a01d
Rename Ably target and scheme to Ably-iOS
ricardopereira Nov 16, 2018
c6e196d
Change Min Deployment Targets of macOS and tvOS
ricardopereira Nov 16, 2018
937ce7b
Add macOS to Fastlane and Travis CI
ricardopereira Nov 16, 2018
cd8ead5
Fastlane: move Scanfile to fastlane folder
ricardopereira Nov 22, 2018
b5ea58a
Test suite: speed up the project setup by moving all Test only depend…
ricardopereira Nov 22, 2018
fdeb731
Test suite: increase timeout for RTL6d1 because sending and confirmin…
ricardopereira Nov 22, 2018
8093e06
Update .travis
ricardopereira Nov 22, 2018
9e3de68
Update Cartfile and Podspec with recent MsgPackAblyFork and ULID vers…
ricardopereira Nov 23, 2018
ee7f1ed
[fix] CocoaPod umbrella header should not include private headers
ricardopereira Nov 29, 2018
cfd33ea
Update README
ricardopereira Nov 30, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@ matrix:
- env: NAME="ably-iOS" LANE=test_iOS11
- env: NAME="ably-iOS" LANE=test_iOS10
- env: NAME="ably-iOS" LANE=test_iOS9
before_install:
- gem install cocoapods -v '1.5.3'
- pod repo update > /dev/null
- env: NAME="ably-macOS" LANE=test_macOS
install:
# CocoaPods
- pod install
# Carthage
- carthage bootstrap --platform iOS
- if [[ ${NAME} == "ably-iOS" ]]; then carthage update --platform iOS --cache-builds; fi
- if [[ ${NAME} == "ably-macOS" ]]; then carthage update --platform macOS --cache-builds; fi
# Update fastlane
- gem install fastlane -v '2.100.1'
- gem install fastlane -v '2.108.0'
before_script:
- xcrun simctl erase all
script:
- export ABLY_ENV="sandbox"
- fastlane $LANE
after_success:
- sleep 5
cache:
directories:
- Carthage
10 changes: 5 additions & 5 deletions Ably.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Pod::Spec.new do |s|
s.version = `Scripts/get-version.sh`
s.summary = "iOS client for Ably"
s.description = <<-DESC
iOS client library for ably.io, the realtime messaging service, written in Objective-C and ready for Swift 3.0.
iOS client library for ably.io, the realtime messaging service, written in Objective-C and ready for Swift 4.0 and later.
DESC
s.homepage = "https://www.ably.io"
s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
Expand All @@ -14,12 +14,12 @@ Pod::Spec.new do |s|
s.platform = :ios, '8.0'
s.requires_arc = true
s.swift_version = '4.2'
s.source_files = 'Source/*.{h,m}'
s.private_header_files = 'Source/*+Private.h'
s.source_files = 'Source/**/*.{h,m}'
s.private_header_files = 'Source/*+Private.h', 'Source/Private/*.h'
s.module_map = 'Source/Ably.modulemap'
s.dependency 'SocketRocketAblyFork', '0.5.2-ably-2'
s.dependency 'msgpack', '0.1.8'
s.dependency 'MsgPackAblyFork', '0.2.0-ably-1'
s.dependency 'KSCrashAblyFork', '1.15.8-ably-2'
s.dependency 'ULID', '1.0.3'
s.dependency 'ULID', '1.0.4'
s.dependency 'SAMKeychain', '1.5.3'
end
1,680 changes: 1,568 additions & 112 deletions Ably.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "856AAC891B6E304B00B07119"
BuildableName = "AblySpec.xctest"
BlueprintName = "AblySpec"
BuildableName = "Ably-iOS-Tests.xctest"
BlueprintName = "Ably-iOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</BuildActionEntry>
Expand All @@ -33,8 +33,8 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "856AAC891B6E304B00B07119"
BuildableName = "AblySpec.xctest"
BlueprintName = "AblySpec"
BuildableName = "Ably-iOS-Tests.xctest"
BlueprintName = "Ably-iOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</TestableReference>
Expand Down Expand Up @@ -63,8 +63,8 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "856AAC891B6E304B00B07119"
BuildableName = "AblySpec.xctest"
BlueprintName = "AblySpec"
BuildableName = "Ably-iOS-Tests.xctest"
BlueprintName = "Ably-iOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
Expand All @@ -81,8 +81,8 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "856AAC891B6E304B00B07119"
BuildableName = "AblySpec.xctest"
BlueprintName = "AblySpec"
BuildableName = "Ably-iOS-Tests.xctest"
BlueprintName = "Ably-iOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "96BF61301A35B2AB004CF2B3"
BuildableName = "Ably.framework"
BlueprintName = "Ably"
BlueprintName = "Ably-iOS"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</BuildActionEntry>
Expand All @@ -33,8 +33,8 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "856AAC891B6E304B00B07119"
BuildableName = "AblySpec.xctest"
BlueprintName = "AblySpec"
BuildableName = "Ably-iOS-Tests.xctest"
BlueprintName = "Ably-iOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</TestableReference>
Expand All @@ -44,7 +44,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "96BF61301A35B2AB004CF2B3"
BuildableName = "Ably.framework"
BlueprintName = "Ably"
BlueprintName = "Ably-iOS"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
Expand Down Expand Up @@ -73,7 +73,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "96BF61301A35B2AB004CF2B3"
BuildableName = "Ably.framework"
BlueprintName = "Ably"
BlueprintName = "Ably-iOS"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
Expand All @@ -91,7 +91,7 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "96BF61301A35B2AB004CF2B3"
BuildableName = "Ably.framework"
BlueprintName = "Ably"
BlueprintName = "Ably-iOS"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
Expand Down
90 changes: 90 additions & 0 deletions Ably.xcodeproj/xcshareddata/xcschemes/Ably-macOS-Tests.xcscheme
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1010"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D7093C09219E2DB200723F17"
BuildableName = "Ably-macOS-Tests.xctest"
BlueprintName = "Ably-macOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D7093C09219E2DB200723F17"
BuildableName = "Ably-macOS-Tests.xctest"
BlueprintName = "Ably-macOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
<AdditionalOptions>
</AdditionalOptions>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
allowLocationSimulation = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D7093C09219E2DB200723F17"
BuildableName = "Ably-macOS-Tests.xctest"
BlueprintName = "Ably-macOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D7093C09219E2DB200723F17"
BuildableName = "Ably-macOS-Tests.xctest"
BlueprintName = "Ably-macOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
</AnalyzeAction>
<ArchiveAction
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
99 changes: 99 additions & 0 deletions Ably.xcodeproj/xcshareddata/xcschemes/Ably-macOS.xcscheme
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1010"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D710D45A219495E2008F54AD"
BuildableName = "Ably.framework"
BlueprintName = "Ably-macOS"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D7093C09219E2DB200723F17"
BuildableName = "Ably-macOS-Tests.xctest"
BlueprintName = "Ably-macOS-Tests"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D710D45A219495E2008F54AD"
BuildableName = "Ably.framework"
BlueprintName = "Ably-macOS"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
allowLocationSimulation = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D710D45A219495E2008F54AD"
BuildableName = "Ably.framework"
BlueprintName = "Ably-macOS"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D710D45A219495E2008F54AD"
BuildableName = "Ably.framework"
BlueprintName = "Ably-macOS"
ReferencedContainer = "container:Ably.xcodeproj">
</BuildableReference>
</MacroExpansion>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
</AnalyzeAction>
<ArchiveAction
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
6 changes: 3 additions & 3 deletions Cartfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
github "ably-forks/SocketRocket" == 0.5.2-ably-2
github "rvi/msgpack-objective-C" "ad0a627becfd27ca45dfa6684b3fc79f058f5ce9"
github "ably-forks/KSCrash" "1.15.8-ably-2"
github "whitesmith/ulid" == 1.0.3
github "ably-forks/msgpack-objective-C" == 0.2.0-ably-1
github "ably-forks/KSCrash" == 1.15.8-ably-2
github "whitesmith/ulid" == 1.0.4
github "soffes/SAMKeychain" == 1.5.3
4 changes: 4 additions & 0 deletions Cartfile.private
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
github "Quick/Quick" == 1.3.2
github "Quick/Nimble" == 7.3.1
github "steipete/Aspects" == 1.4.2
github "SwiftyJSON/SwiftyJSON" == 4.2.0
8 changes: 6 additions & 2 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
github "Quick/Nimble" "v7.3.1"
github "Quick/Quick" "v1.3.2"
github "SwiftyJSON/SwiftyJSON" "4.2.0"
github "ably-forks/KSCrash" "1.15.8-ably-2"
github "ably-forks/SocketRocket" "0.5.2-ably-2"
github "rvi/msgpack-objective-C" "ad0a627becfd27ca45dfa6684b3fc79f058f5ce9"
github "ably-forks/msgpack-objective-C" "0.2.0-ably-1"
github "soffes/SAMKeychain" "v1.5.3"
github "whitesmith/ulid" "1.0.3"
github "steipete/Aspects" "1.4.2"
github "whitesmith/ulid" "1.0.4"
14 changes: 0 additions & 14 deletions Podfile

This file was deleted.

Loading