Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push State Machine: main thread sometimes gets stuck when accessing Local Device #826

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Push State Machine: main thread sometimes gets stuck when accessing Local Device #826

merged 2 commits into from
Jan 21, 2019

Conversation

ricardopereira
Copy link
Contributor

No description provided.

paddybyers
paddybyers approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on the detail, but this looks like you're resolving a deadlock by serialising some events through a different thread?

@ricardopereira
Copy link
Contributor Author

@paddybyers Yes, if you try to access the local device by, i.e., trying to subscribe your device, and at the same time call activate (which syncs the main thread) then it could do a deadlock.

barrier queue ably stacktrace

@ricardopereira ricardopereira merged commit e0c8277 into develop Jan 21, 2019
@ricardopereira ricardopereira deleted the fix-push-state-machine branch January 21, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardopereira @paddybyers