Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carthage: fix public header imports #902

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Carthage: fix public header imports #902

merged 2 commits into from
Oct 9, 2019

Conversation

ricardopereira
Copy link
Contributor

No description provided.

paddybyers
paddybyers approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really comment on this in detail, but LGTM.

But please make this PR against a new release branch instead of develop as discussed.

@ricardopereira ricardopereira merged commit a99b5e7 into develop Oct 9, 2019
@ricardopereira ricardopereira deleted the carthage-issue branch October 9, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardopereira @paddybyers