Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SUSPENDED channel reattach #909

Merged
merged 10 commits into from
Jan 6, 2020
Merged

Fix SUSPENDED channel reattach #909

merged 10 commits into from
Jan 6, 2020

Conversation

ricardopereira
Copy link
Contributor

Fixes #881.

@ricardopereira
Copy link
Contributor Author

ricardopereira commented Oct 27, 2019 •
edited
Loading

Cherry picked a fix made in another PR: 3cbca52.

@ricardopereira ricardopereira marked this pull request as ready for review October 27, 2019 23:55
@ricardopereira
Merge branch 'develop' into fix-881
c88fa21
@ricardopereira
Channel suspended retry timer from RTL13
45c21e4 
is only for if the channel refuses to become attached while the
connection is connected.
@ricardopereira
fixup! Channel suspended retry timer from RTL13
742a252 
is only for if the channel refuses to become attached while the
connection is connected.
@ricardopereira
Fix RTL3d test: no unconditional retry timeout when channel go into s…
0eaae96 
…uspended

If a channel goes into suspended as a side effect of a connection state
change, it should not have any kind of independent retry timeout of its
own volition; it should just sit there doing nothing until the
connection state becomes CONNECTED, which should have the side effect of
triggering all suspended channels to reattach.
@ricardopereira
Copy link
Contributor Author

@SimonWoolf Please review the last parts. Thanks

@ricardopereira ricardopereira merged commit d94c6c6 into develop Jan 6, 2020
@ricardopereira ricardopereira deleted the fix-881 branch January 6, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonWoolf SimonWoolf SimonWoolf approved these changes

@paddybyers paddybyers Awaiting requested review from paddybyers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Realtime Channel endless loop: suspended > attached > suspended
2 participants
@ricardopereira @SimonWoolf